Allow views to move based on keyboard even when not having first responders#335
Open
dineshflock wants to merge 2 commits intohuri000:masterfrom
Open
Allow views to move based on keyboard even when not having first responders#335dineshflock wants to merge 2 commits intohuri000:masterfrom
dineshflock wants to merge 2 commits intohuri000:masterfrom
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #335 +/- ##
=========================================
- Coverage 2.04% 2.04% -0.01%
=========================================
Files 96 96
Lines 5472 5489 +17
=========================================
Hits 112 112
- Misses 5360 5377 +17 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
I tried this, but when entry dissmissed, it dismiss without animation :( |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Goals 🥅
Currently keyboard binding only works if entry responds true for containsFirstResponder()
This PR will now allow consumers to create entries that are bound to Keyboard even when they have no first responders.
Implementation Details ✏️
Another case .bindAlways that can be used to bound an entry to Keyboards irrespective of firstResponder state.
Renamed old .bind case to .bindWhenResponder
Testing Details 🔍
Manually tested
TODO: Code as per repo conventions. Frankly I have not read the conventions. I will do once this PR seems eligible to be merged.